martialblog/docker-limesurvey

Add additional check for $ENCRYPT_SECRET_BOX_KEY to the entrypoint-security.php-creation

wuarmin opened this issue · 3 comments

wuarmin commented

Hey,

I think the env variable $ENCRYPT_KEYPAIR is not used at newer versions. So we should add a check for the presence of $ENCRYPT_SECRET_BOX_KEY to decide if the security.php file should be created. WDYT?

docker-limesurvey/6.0/apache/entrypoint.sh

Line 156 in 7e73bf5

if [ -n "$ENCRYPT_KEYPAIR" ]; then 

if [ -n "$ENCRYPT_KEYPAIR" ] || [ -n "$ENCRYPT_SECRET_BOX_KEY" ]; then

best regards

martialblog commented

Hi,

you mean newer versions of LimeSurvey? Yes if the current LS version doesn't use this anymore, we can update the condition for the security.php.

Do you want to open a PR?

Thanks for noticing

wuarmin commented

Hello @martialblog,

you mean newer versions of LimeSurvey?

Yes I mean versions >=5. We use version 6 and have to provide a dummy $ENCRYPT_KEYPAIR to make the composing work.
I created a #174

best regards

martialblog commented

Merged and I just added the new LS tags, so the Images will be updated shortly.

Thannks!