martin-helmich/phpunit-json-assert

Fix "CleanCode/BooleanArgumentFlag" issue in src/Constraint/JsonValueMatches.php

martin-helmich opened this issue · 0 comments

martin-helmich commented

The method __construct has a boolean flag argument $matchAll, which is a certain sign of a Single Responsibility Principle violation.

https://codeclimate.com/github/martin-helmich/phpunit-json-assert/src/Constraint/JsonValueMatches.php#issue_566f488bd3c9f1000107139d