Feature Request: User Authentication
Closed this issue · 12 comments
HockeyApp SDK supports the following:
Anonymous auth
Device UUID Auth
HockyApp User Login Auth
Email Auth
Web Auth
react-native-hockeyapp only supports anonymous. Are there any plans to support additional authentication mechanisms?
If there's no short term goals to making this happen, I'm willing to contribute and can look at iOS early next week
@berickson1 I don't have the plan. So I would be really happy if you do it and I could probably do Android version. So feel free to work on it.
Cool. We should agree upon an interface. Here's my proposal:
Function: HockeyApp.configure
Parameters:
HOCKEY_APP_ID:string
autoSendCrashReports:boolean (default = true)
authType enum (default = 0)
app_secret: string (default = "")
Enum values:
0 - No Auth
1- Email (& Secred) Auth
2 - HockeyApp User Login Auth (email & password)
3 - Device UUID Auth
4 - Web auth (iOS only)
If you're ok with this, I'll start on iOS. Thoughts?
Looks good. 👍
Just one observation... Maybe the naming of the var could be all camel case?
Sounds good, I wasn't sure what naming convention you preferred.
I've implemented iOS auth types. I'll hold off making a pull request because it will break android (differing api call signatures).
Take a look at it here: 81e3793
Thoughts?
Looks good to me with 1 comment on the commit. Feel free to create PR and next week when I'm back from skiing I'll write the Android version of it.
@martincik, @rspeyer implemented the Android piece. Feel free to take a look here: da086f6
I'll put up a pull request tomorrow for iOS/Android combined
Awesome! I was actually planning to send a PR for this, but you beat me to the punch :)
@berickson1 @rspeyer Looks good! Let's do PR.
@martincik it looks like it has already been pulled in via the auth branch - here is the relevant diff: 81e3793...master