maruohon/enderutilities

Handybag items get deleted

EDToaster opened this issue · 4 comments

Version: enderutilities-1.12.2-0.7.12.jar
Modpack: SkyFactory 4 (4.0.8), Minecraft 1.12.2, forge-14.23.5.2838

Sometimes when sorting the player inventory with the bag in the inventory, the bag gets sorted into the handy bag itself, which then deletes all the items that were in the bag.

I'll try to reproduce it again, but I think this is just a one-off thing.

This is supposed to be impossible to do. Which sorting function do you mean exactly? The player inventory sort button in the bag GUI, or one of the move-items buttons, or something external such as Inventory Tweaks?

Not sure what caused it. I pressed the "Sort Player Inventory" in the middle of the GUI. Trying to reproduce it now, but I'm having trouble doing so. The bug happened when my inventory was quite full, so that may be an issue? I'll try to see what I can gather from my end.

Steps to reproduce

  1. Grab 2 or more unstackable items
    2019-08-17_15 18 08

  2. Sort those items (They will become stacked, a bug?)
    2019-08-17_15 18 15

  3. Fill remainder of inventory with any (stackable) item
    2019-08-17_15 18 28

  4. Sort again
    2019-08-17_15 18 30

  5. The stacked unstackable items will become unstacked, which then somehow deletes the handybag.

Causes

I think there are two bugs here.

  1. Unstackable items should not be stacked upon sorting
  2. When sorting an inventory results in more itemstacks than there are itemslots, the remaining itemstacks should be thrown into the world, rather than being deleted.

Hope this helps!

EDIT: This bug also seems to duplicate non-stackable items. In step 3 there are 6 chestplates. However, in step 4, we have 2 extra chest plates. I just restarted my world and confirmed this isn't a client side bug.