marvin-nyalik/Recipe-App

Kanban-Setup

Closed this issue · 2 comments

AbelG101 commented

Hi @AnsarIbrahim, @marvin-nyalik & @Zafron047 👋,

You're doing a good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

  • Proper kanban template is used ✔
  • Each card is assigned a team member ✔
  • Tasks are distributed fairly ✔

Required Changes ♻️

  • Excellent progress so far, everyone! I've noticed that we're almost there, but we missed a few requirements. To ensure completeness, let's address them by adding separate task cards for each of the following requirements:
    • Make sure there are no N+1 queries happening.
    • Write unit and integration tests
    • Recipe details: Should have a modal to choose an inventory to create a shopping list with, as in the wireframe.
    • Follow the layout of the wireframes provided. Personalize the rest of the design including colors, typographies, spacings, etc.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better.

You can also consider:

  • N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

thecodechaser commented

STATUS: APPROVED 🟢

Hi @marvin-nyalik, and Team👋,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

  • 👍1