massalabs/station-massa-wallet

Add Op. cost calculation and explain fee-parameters to wails pop-ups: CallSC, ExecuteSC, Transaction, Roll buy/sell

Thykof opened this issue · 4 comments

Thykof commented
  • front: operation cost CallSC
  • front: edit fees CallSC
  • front: refactor: move operation cost (label + accordion) into Sign.tsx as a child of CallSC, ExecuteSC, BuySellRoll, Transaction
  • back: edit fees: plug to prompter
  • WIP front: update ExecuteSC and other op type
  • back: edit fees: plug to sign endpoint
  • change the API to return the modified operation along side with the signature
  • create an issue on station for that breaking change: massalabs/station#1254
  • create an issue on wallet provider side for the breaking change: massalabs/wallet-provider#179
loonggamma commented

1 - Transaction, sent from MW, with edited and confirmed fees.

  • Balance of sending address: 999.99
  • sent amount: 100
  • custom fee (operation cost): 1
  • total cost on sender: 101 MAS

Expected balance of sender: 999.99 -> 898.99
Expected balance of recipient: 0 -> 100 - 0.01 (for new address storage)

Actual Result:

  • Actual Balance of sending address decreased to 899.99
  • Balance of receiving address: 99.99 - ok!

Here's operation on the Explorer: https://explorer.massa.net/operation/O12Tpwq4eKq613kqUFP7AxjqD6CZvQxRLDCdmKqRg4CSSmrjB5kA/

fees.not.taken.mov
loonggamma commented

2- Unable to test Postman cases in real conditions

tested all: Call SC, Execute SC examples with change of fees.

  • I can't test in reality if change of fee parameter is bugged for other operation types, like in Transaction case above.
    The operation can be found in explorer but they are not showing any proper params (I assume because it's example requests that don't make sense from postman, but need confirmation).

  • Used an example with this wallet address set as nickname.

  • Edited 'fee' parameter

  • Designs are okay, front looks good.

Execute.SC.editable-.from.Postman.mov
loonggamma commented

3 - "i" tooltip for 'Description' accordion is empty.

  • if quick (a few minutes): add "Description provided by a dApp",
  • if not quick: can be hidden for now
Thykof commented

1 - Transaction, sent from MW, with edited and confirmed fees.
I fix in #838

2- Unable to test Postman cases in real conditions
I tested with robot framework real transactions, it works as expected, I can see the fee field in the block explorer

3 - "i" tooltip for 'Description' accordion is empty.
here is the PR: #839