masterexploder/PHPThumb

Merge 2.0 branch into master

Closed this issue · 13 comments

I would suggest creating a tag at the current state of master and then merge in version 2.0.

I understand version 2.0 works a lot different then the current version. When the merge is performed, the repository can be submitted to Packagist and Travis-CI, and people can also update the documentation.

Thoughts @masterexploder and @Blackshawk?

I'm all for v2.0 becoming the master. There'll need to be some effort toward updating documentation, especially since I busted backward-compatibility with all existing plugins. They aren't difficult to rewrite but its little things like that that will need some attention.

What if there was a timeline to the merge?

March 31 - Docs update
April 30 - Merge into master

That timeline seems fine; here's what we need to accomplish.

  • Update the current master README with a note explaining the upcoming switch, and that 1.0 is now slated for deprecation.
  • All future pull requests need to be submitted against the 2.0 branch.
  • 2.0 needs docs on the new plugin interface. Old plugins won't work w/ 2.0 - there was no saving that architecture.
  • 2.0 needs docs on using the library w/ Composer.

I can contribute here and there, but I'm swamped at my day job and have a kid on the way so I don't have much free time anymore.

I will agree to the timeline, and I hope to be able to put more effort when I am free from ongoing work.

I just pushed a v1.0-final tag to the project.

The rest of the next two months should be spent cleaning up the 2.0 branch and docs, and prepping it for a final merge into master. At that point, we will also push a v2.0 tag.

The project should use tags from here on out, since we don't want people to have to mark their dependencies in composer.json as development.

Hi there,

Thank you for great library!

Could you please merge 2.0 and put it into packagist. There're already more than 1200 installs of this fork, but it isn't maintained and still has issues with exceptions namespace.

Completing the merge today.

Hi ! Is the v2.0 pkuggable on Zend Framework 2 (without any modifications) ? Thank you

Should be. Working on integrating Composer support right now.

@masterexploder Do you want to submit the project to Packagist? That way the project retains proper namespacing. Once you submit it should start working immediately.

2.0 branch merged into master - pushed tag for 2.0.

Documentation changes in the wiki need to begin immediately.

Thank you! Will definitely check soon.

Very great ! Thank you once more