matchai/spacefish

pyenv section not being displayed correctly

ccarterlandis opened this issue · 4 comments

Bug Report

Current Behavior
When I activate a Python virtual environment, the name of the environment appears on the line above the prompt, devoid of any styling save for a pair of parentheses. AFAIK, this is just the default way Python displays a virutalenv.

Expected Behavior
I would expect the virtualenv section to appear inline with the rest of prompt and be formatted correctly.

Relevant Fish Configuration

set SPACEFISH_PROMPT_ORDER time user dir host git package node golang haskell pyenv exec_time line_sep battery jobs exit_code char
set SPACEFISH_CHAR_SYMBOL ∫

Environment

  • Spacefish version: [the output of echo $SPACEFISH_VERSION] 2.6.1
  • Fish version: [the output of fish --version] 3.0.2
  • Fish plugin manager: [e.g. oh-my-fish, fisher, fin] fisher
  • Terminal emulator: [e.g. iTerm, Hyper, Terminator] iTerm2
  • Operating system: [e.g. OSX 10.13.4, Windows 10] macOS Mojave v10.14.3

Possible Solution

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

Before activating the virtual environment:
Screen Shot 2019-08-16 at 11 33 06 AM

After activating the virtual environment:
Screen Shot 2019-08-16 at 11 33 32 AM

Thanks!

Hi @ccarterlandis. Thank you for opening an issue.
Unfortunately spacefish is no longer under active development, but I suggest you take a look at its successor https://github.com/starship/starship, which has similar pyenv support built-in.

That said, if someone comes around with a PR to fix this bug, I'll gladly review and merge it. 😄

@matchai oh wow, I had no idea there was a successor! I found a link to this prompt here and liked it so much I instantly downloaded it! I would have preferred to just start with the sucessor but the install was so easy I don't think I'll have to worry to about installing a new one. Thanks for letting me know!

For future people - rather than pyenv in SPACEFISH_PROMPT_ORDER you need to set venv. :)

And for future readers, you also need to set VIRTUAL_ENV_DISABLE_PROMPT to 1 to disable the default fish prompt integration done by venv.