Cannot load compressed .ico files

Question

Cannot load compressed .ico files

Opened this issue 4 years ago · 7 comments

James-E-A commented 4 years ago

Expected behaviour

The image should display.

Actual behaviour

Could not load image …
Compressed icons are not supported.

Steps to reproduce the behaviour

Click this link and open the resulting file in Eye of Mate

MATE general version

1.24.2

Package version

eom-1.24.2-1.fc32

Linux Distribution

Fedora 32

Link to bugreport of your Distribution (requirement)

https://bugzilla.redhat.com/show_bug.cgi?id=1963750

Answer 1 · 2021-05-23T23:00:42.000Z

I don't see that eom is crashing. This icon is simply not supported.

Answer 2 · 2021-05-24T00:10:43.000Z

I did some further testing and it appears the issue is with PNG-compressed .ico files, rather than anything to do with size

Example outputs from FILE(1):

MS Windows icon resource - 3 icons, 48x48, 32 bits/pixel, 32x32, 32 bits/pixel - Supported
MS Windows icon resource - 1 icon, 16x16 with PNG image data, 16 x 16, 8-bit/color RGBA, non-interlaced, 32 bits/pixel - Not supported

Answer 3 · 2024-03-01T19:14:20.000Z

please implement a way to view compressed icon files

Answer 4 · 2024-03-05T06:18:14.000Z

Note that we are a very small team, and it could take quite a while to get to something like this on our own. I myself have done very little with eom other than testing PR's and bugfixes so will have to leave this for someone on the team that knows what they are doing. As always, if someone outside the team submits a PR of their own for this we will be happy to try it out.

Answer 5 · 2024-03-06T11:03:26.000Z

please implement a way to view compressed icon files

I am sorry for posting this, I searched for the problem for another program (mentioned that one in the google search), clicked a github link to an already existing issue that sounded exactly like it, and didnt look at the project name again. Don't feel pressured into implementing a feature that no one really asks for

Answer 6 · 2024-03-06T18:43:19.000Z

Not to worry: feature requests give developers (and new developers) a popularity contest for potential new features and can help guide the roadmap for a program. Not all will be used in any program popular enough to attract them, but some will be and widely requested items can tell devs what they may have missed. Example: if a new archive manager written by someone using only Debian could unpack .deb files but not .rpm files that would be an oversight and someone on Fedora would probably ask for .rpm support or even submit a PR for it if they have the skills.

Also note that a feature request from one person may attract a PR submitted by another with similar needs.

In this case, lots of people working on linux/unix systems will never encounter microsoft compressed icons, but that could change.

Suppose Microsoft decided to lock all versions of MS windows to the Microsoft Store and disable all installation of software from outside it with no unpaid option to switch away from that. This would effectively ban Steam, which is exactly why discussion of such things a decade ago forced Steam to experiment with Linux support as both an insurance policy and a shot across Microsoft's bow. Had that run to completion, lots of devs from the Windows world might have shown up in the Linux world, making a feature request like this one important and probably bringing a PR from one of them.

Answer 7 · 2024-03-06T20:35:12.000Z

This should be implemented in GdkPixbuf I believe, and there seems to be some unfinished work for it. I guess if anybody want to take that one it could be merged there :)