netspeed unusable on vertical panels
pF-arQon opened this issue · 5 comments
Expected behaviour
netspeed accurately displays network activity
Actual behaviour
netspeed displays what is effectively random numbers
Is that 5 megabits? 85? 965? Your guess is as good as mine. :)
Steps to reproduce the behaviour
Create a vertical panel, add the netspeed applet to it.
MATE general version
1.26
Package version
Linux Distribution
Ubuntu 22.04
Link to bugreport of your Distribution (requirement)
https://bugs.launchpad.net/ubuntu/+source/mate-applets/+bug/1841854 , which contains fixes for both this and the icon positioning bug
I just tested a bunch of left panel widths, and found that this applet simply does not manage space well when confined horizontally. The minimum width necessary to allow the applet to be useful would be the amount needed to accomodate the decimal places though, it's never going to be possible to make it very useful on say, a 24 px vertical panel.
Three things could help though: shrinking instead of cutting the icon, being able to remove the units or place the units label under the numbers, and maybe ellipsizing the label text so that the least significant figure would always be the first to go, even with the panel on the right side of the screen.
Anyway, here's what I got:
On a 100px left panel:
On a 76px left panel
On a 56 px left panel:
On a 36 px left panel:
Yeah, there are multiple issues with the code, though the icon problems are minor compared to the applet being literally nonfunctional since the 1.26 regression.
Like I say, all the bugs I've seen so far are fixed in the patches I posted six weeks ago, including the icon: they just need someone to actually merge them. There's not much point discussing cosmetic changes while even the most basic pieces are still broken, because the situation will be different once those are working.
In the first post:
https://bugs.launchpad.net/ubuntu/+source/mate-applets/+bug/1841854 , which contains fixes for both this and the icon positioning bug
There are more bugs with it - as you say, it's just not very good at coping with spacing/orientation - but my time is limited so I had to prioritize making it functional first.
We cannot test and merge a PR from launchpad etc w/o manually cutting and pasting it into a PR ourselves. If you could do that we could then much more easily test it