[Feature Request]: pymatgen Incar may not be compatible with monty class
zhongpc opened this issue · 1 comments
zhongpc commented
Email (Optional)
No response
Problem
In monty.json line 293, when Incar is initiated with a dictionary, e.g. {'ALGO': 'Fast', 'EDIFF: 1e-5, ...}
new_obj = cls(**__input_value) does not work for such a case.
The issue will occur when applying to the workflows with jobflow & atomate2
Proposed Solution
Include new_obj = cls(__input_value) for the class such as Incar
Alternatives
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
zhongpc commented
Found the issue could be resolved by downgrading pydantic<=2.4.2