mathias234/binary_rw

Test failure due to "out_of_range" temp file shared between tests getting stomped

Closed this issue · 0 comments

The read_write_string and read_out_of_range tests both use the temporary file out_of_range (looks like a copy-and-paste error?). Depending on when the tests are run (as they are run in parallel by default), there will be some issues with them stomping on each other.

Test output showing the failures:

test read_write_from_memorystream ... ok
test read_write_test_i8 ... ok
test read_write_test_i16 ... ok
test read_write_test_f32 ... ok
test read_write_test_i32 ... ok
test read_write_string ... FAILED
test read_out_of_range - should panic ... FAILED
test read_write_bytes ... ok
test read_write_test_u32 ... ok
test read_write_test_u16 ... ok
test read_write_test_f64 ... ok
test read_write_test_u8 ... ok
test read_write_test_i64 ... ok
test read_write_test_isize ... ok
test read_write_test_usize ... ok
test read_write_test_u64 ... ok
test seek_test ... ok

I have some fixes that address this, will be putting up a PR shortly.