mathnet/mathnet-symbolics

Necessity of the module NumericLiteralQ

FoggyFinder opened this issue · 3 comments

FoggyFinder commented

I'm not sure in target of the module NumericLiteralQ.

The four from five functions is duplicate from the module Operators

The last one function FromString is simple, so maybe better just remove this module?

cdrnet commented

The point of this module is to allow the 4Q notation directly in F# source code (F# compiler conventions). The module is not intended to be used by other means.

  • 👍1
  • 🎉1
FoggyFinder commented

Oh, really - I had to check before creating issue...

cdrnet commented

I guess a code comment at that module explaining its purpose would not be wrong, especially since it involves "compiler magic" :)