mathurinm/celer

Turn print statement into a warning

jolars opened this issue · 2 comments

Please consider turning this print statement into a warning (that can be filtered out via warnings.filterwarnings()):

celer/celer/lasso_fast.pyx

Lines 357 to 358 in 83c4628

print("!!! Inner solver did not converge at epoch "
"%d, gap: %.2e > %.2e" % (epoch, gap_in, tol_in))

I agree it would be way better to raise a ConvergenceWarning as we do below. Can you send a PR ?