maticnetwork/bor

Support compilation with Go 1.23

Closed this issue · 4 comments

yorickdowne commented

Feature

Compilation with Go 1.23 currently fails. Go 1.22 works

26.20 go: downloading go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc v0.49.0
26.22 go: downloading github.com/felixge/httpsnoop v1.0.4
84.03 # command-line-arguments
84.03 link: github.com/fjl/memsize: invalid reference to runtime.stopTheWorld
84.18 make: *** [Makefile:28: bor] Error 1
yorickdowne commented

Go team rejected the memsize author’s proposal to make memsize work with Go 1.23.

Upstream go-ethereum fixed this by removing memsize in this patch: ethereum/go-ethereum@e467577

klestrong commented

@yorickdowne
Thank you! Your post is much appreciated. I can confirm specifying Go 1.22 successfully completed the build for me and has resolved my issue in the previous ticket I posted.
#1306 (comment)

marcello33 commented

We applied the same patch from go-ethereum here
It will be eventually merged and released with the next release.
In the meantime, you can apply the workaround by changing the version in the Dockerfile.
Thank you.

  • 🚀1