matinzd/rn-bottom-sheet

Styling issues

Opened this issue · 2 comments

Nirony commented

Hi there, all in all, great library.
I am facing with some styling issues that can be resolved is a simple manner.

my implementation is in such way that when the drawer is open, the rest of the screen is getting darker - I'm using an absolute view with opacity to manage that.
the problem here is that in android this view is going above the drawer.
I tried many workarounds and each came up with another issue.
the simplest way to solve this is to add to "animationContainer" style in Animator.js - zIndex: 9999 - or better yet add a "customStyle" prop.

In addition, there is another issue I faced with the "SCREEN_HEIGHT" constant which is not accurate when using the soft navigation bar in android. https://github.com/Sunhat/react-native-extra-dimensions-android should fix that.

Please tell me if you need any other info on those issues.
Thanks,

matinzd commented

I will work on these issues, thanks for your collaboration!

  • 👍1
Joeao commented

The previous commit crashed the project due to referencing this outside of the class.

Issue happens on this line: 9d6a101#diff-d29b81ae7802b48f16ffe3d79d002305R106

I made a pull request #6

  • 🎉1