matschik/vue-hero-icons

Typescript types

shaharmor opened this issue · 2 comments

shaharmor commented

Hey,

Great library.
Any chance to get typescript definitions?

matschik commented

Hello !

I'm not using Typescript in my projects currently.
Feel free to submit a PR and I would be happy to review it :)

Or do you know any VueJS library on Github with Typescript definition in a separate file like "index.d.ts" ? I need to know the best practices.

medz commented

@shaharmor Maybe https://github.com/bytegem/vue-heroicons is a better choice.

@matschik Using index.d.ts to define types is a good choice. Even if your source code is built with ts, you still need to convert ts to .d.ts file. My approach is to directly generate es6 module and types based on the source warehouse svg. I think https://github.com/bytegem/vue-heroicons/tree/master/types can give you a good inspiration.