matt-allan/laravel-code-style

Config ?

mskenderian-wps opened this issue · 5 comments

this is supposed to point to a file?
->notPath(database_path('migrations'))

I’m sorry, I don’t understand the question. That line is excluding the migrations because they violate one of the PSR rules and the fixer will try to rename them.

Documentation states it must be a file.
exclude is what we need to use.

image

It looks to me like both the docblock and the Symfony documentation both state that notPath accepts directories:

https://github.com/symfony/symfony/blob/4.3/src/Symfony/Component/Finder/Finder.php#L271
https://symfony.com/doc/current/components/finder.html#path

The php-cs-fixer Finder just adds a few default rules, it's not modifying how notPath works.

Is this is causing an issue for you could you explain what the issue is? Are your migrations being modified by the fixer?

any word?