mattak/Unidux

StateJsonEditor should ignore package.json

Closed this issue · 7 comments

shiena commented

StateJsonEditor should ignore package.json because upm's package.json is displayed by a dedicated Inspector.
This can be avoided by ae28b2e in #142.

View the inspector of package.json before unidux installation
image

View the inspector of package.json after unidux installation
image

mattak commented

@shiena
Thanks for your mentions!
I created this editor extension for editing state json.
State json can be saved and loaded on the UniduxPanel.
(e.g. save count data on the scene and edit and load the data)

I think black listing style will be cost (excluding specific file, such as package.json)
UnityEngine and the other assets may control other filename json in future.

So I think white listing style would be better.
For example, using filename suffix such as .state.json or .unidux.json.
or remove this feature completely and export to the other assets might be good.

How do you think about this idea?

shiena commented

@mattak
I think the filename suffix idea is certainly better than the exclusion rule.
For those two, I would prefer the more unique .unidux.json.

  • 👍1
mattak commented

Thanks! I'll change it as soon as possible.

mattak commented

@shiena

I created new release 0.4.1 for fixing package.json bug!

Current Inspector of package.json

  • 🎉1
shiena commented

@mattak
Now that upm is supported, I've registered for openupm.
https://openupm.com/packages/me.mattak.unidux/

openupm requires the same git tag as the version in package.json.
Therefore, it would be very useful if you could update the version of package.json to 0.4.1 and re-tag it with the git tag.

  • 👍1
mattak commented

@shiena Thanks! I forgot to update UPM version.
To avoid the issue, I've created release script.
https://github.com/mattak/Unidux/blob/master/script/release.sh

I think pushed git tag should not be overwritten.
So I rolled out next version 0.4.2 and fit UPM version and git tag version.
I'm not permitted to operate openupm, so please apply the settings to detect new version tag.

shiena commented

@mattak Thanks you.
The version of package.json and the git tag have been matched, so it will be automatically applied to openupm.
https://openupm.com/packages/me.mattak.unidux/?subPage=pipelines

  • 👍1