The build fails.
Closed this issue · 7 comments
https://drone.io/github.com/mattbaird/elastigo/latest
This indicates that the build script is trying to cd into a now defunct directory. I suspect that what you really want to do is go build ./....
Hmm. I changed https://github.com/mattbaird/elastigo/blob/master/.travis.yml
to go build ./... yesterday but it didn't stick.
Hey everyone, we're working on this, tests run clean for @shutej and myself on linux + mac, something funky is still happening in Drone. Does anyone have a theory?
Build is succeeds for me on linux+mac. Would it have to do with elasticsearch version in drone? https://github.com/drone/drone/blob/master/pkg/build/images.go
I'm testing with 772a5c2 on Linux (Ubuntu 14.10) and OS X against dockerfile/elasticsearch. Both fail with:
--- FAIL: TestGetAll (7.90 seconds)
assert.go:15: /Users/bac/gopath/src/github.com/mattbaird/elastigo/lib/clusternodesinfo_test.go:25
assert.go:36: ! Failure
assert.go:38: ! - should not have gotten error, received :json: cannot unmarshal number into Go value of type string
Running on Ubuntu against an installed elasticsearch 0.90.0 I get more failures similar to what drone.io is showing.
More information regarding the failing tests. The tests fail when run against elasticsearch in a Docker container using dockerfile/elasticsearch. That version of elasticsearch is 1.3.2.
I reverted elasticsearch to 1.2.2 and rebuilt a new Docker container. Running the elastigo tests against 1.2.2 results in all tests passing.
The maintainers of dockerfile/elasticsearch have been asked to tag their builds with release numbers which would make setting up a known-good environment easier. So far they have not acted on that request.
attn: @mattbaird
This may relate to my pull request:
If you merge that change and try again, does the failure go away?
Basically, somewhere in there, ElasticSearch got it in its head that the
status bool should be returned as a string. I tried to patch that.
Jeremy
Jeremy
On Wed, Aug 27, 2014 at 8:37 AM, Brad Crittenden notifications@github.com
wrote:
More information regarding the failing tests. The tests fail when run
against elasticsearch in a Docker container using dockerfile/elasticsearch.
That version of elasticsearch is 1.3.2.I reverted elasticsearch to 1.2.2 and rebuilt a new Docker container.
Running the elastigo tests against 1.2.2 results in all tests passing.The maintainers of dockerfile/elasticsearch have been asked to tag their
builds with release numbers which would make setting up a known-good
environment easier. So far they have not acted on that request.attn: @mattbaird https://github.com/mattbaird
—
Reply to this email directly or view it on GitHub
#108 (comment).
Hi @shutej ,
With your branch running against ES 1.3.2 I get one failure:
--- FAIL: TestGetAll (27.76 seconds)
assert.go:15: /Users/bac/gopath/src/github.com/shutej/elastigo/lib/clusternodesinfo_test.go:25
assert.go:36: ! Failure
assert.go:38: ! - should not have gotten error, received :json: cannot unmarshal number into Go value of type string
Do you see that failure when you run locally? I am testing in OS X against ES in docker:
docker run -d -p 9200:9200 -p 9300:9300 dockerfile/elasticsearch