matteocrippa/awesome-swift

GradientProgressBar listed twice

MatrixSenpai opened this issue · 6 comments

MatrixSenpai commented

fxm90/GradientLoadingBar appears twice in the Awesome List

  • Once under UI ("GradientProgressBar - A customizable gradient progress bar (UIProgressView)")
  • Once under HUD ("GradientLoadingBar - An animated gradient loading bar.")

One of these should be removed, probably the entry in UI, since HUD is a smaller category

fxm90 commented

Those we‘re actually two different Pods ...

One is a subclass of UIProgressView, the other one adds an infinte loading indicator to the top.

MatrixSenpai commented

Please actually read the PR. This removes a duplicate entry. You can verify this by looking at the README file pre-PR and search for your username. It will appear twice, with the exact same repository. If they're different pods, I recommend submitting another PR with a different link :)

fxm90 commented

I've read the PR, but the entry you removed was not a duplicate. The pods GradientLoadingBar and GradientProgressBar are actually two different ones.

See the urls to the homepage are different as well:

      "homepage": "https://github.com/fxm90/GradientLoadingBar"	
      "homepage": "https://github.com/fxm90/GradientProgressBar"

With your changes the pod "GradientProgressBar" is removed from the directory, leaving only "GradientLoadingBar" in the list.

MatrixSenpai commented

Interesting. I didn't actually notice that. My apologies. They look pretty similar 😂
@dkhamsing roll back?

matteocrippa commented

Easier, make a new PR and put but the entry

fxm90 commented

@MatrixSenpai Will you take care of this? :)