Remove broken link
dkhamsing opened this issue · 5 comments
That link was referenced in a test failure for #1732:
> White listed:
1. [L0005] 301 https://itunes.apple.com/us/app/awesome-for-swift-cheatsheet/id1078115427 → https://apps.apple.com/us/app/awesome-for-swift-cheatsheet/id1078115427
2. [L0688] 307 https://theswiftwebdeveloper.com → https://medium.com/m/global-identity?redirectUrl=https%3A%2F%2Ftheswiftwebdeveloper.com%2F
3. [L1247] 429 https://github.com/tadija/AERecord
4. [L4985] 200 http://online.swiftplayground.run
Issues :-(
> Links
1. [L0678] 404 https://itunes.apple.com/us/course/developing-ios-9-apps-swift/id1104579961
> Dupes
None ✓
@dkhamsing do you have a fork with the link fixed?
No but it should not affect your pull request.
What's present doesn't explain why the test failed, and it seems I can't download any further runtime logs: https://github.com/matteocrippa/awesome-swift/runs/4707532462?check_suite_focus=true
Given that you are a maintainer of this repository, do you know anything about the testing suite that might be causing tests to fail? I added another category at the same time as adding a new item, so would that cause a problem?
Pull requests gives us an opportunity to check links in the repo. We found a broken link. It's not your responsibility to fix it.
Don't think the category is the problem.
Right, it looks like the last several PRs also had failing tests. Thanks for the information!