mattgodbolt/jsbeeb

Parity in tapes is ignored.

CommanderCoder opened this issue · 1 comments

Comparing the byte in the UInt8Array with the string won't work here:

jsbeeb/tapes.js

Line 105 in 09ebe87

numParityBits = parity !== "N" ? 1 : 0;

I couldn't find a BBC tape that falls foul of this error but when I was trying out files for the Acorn Atom I could only get this to work by converting to a string character first using fromCharCode.
https://github.com/CommanderCoder/JSATOM/blob/fb0a1147bf678a569c6e55338a85be5f81d8aaa7/tapes.js#L171

Oh yikes, nice spot!