matthewsimo/scss-flex-grid

No way to reset an offset

Closed this issue · 5 comments

rjgrazioli commented

I'm setting my col to .off-sm-5 and would like to remove the offset on a larger screen. Would a .off-md-0 make sense here?

matthewsimo commented

You can pretty easily create a .offset-reset class that sets margin-left to zero and apply it to the element. I'm going to put this on hold and if enough folks want it, I don't see harm in adding it in.

timogwl commented

Got exactly the same issue and had the same thoughts as @rjgrazioli. .off-md-0 or .off-md-reset (with a media query class) would make more sense to me.

timdiacon commented

+1 from me

.off-md-0

Would make sense to me 👍

matthewsimo commented

Hey - quick update on this front. I got a working solution in place but I'm still testing it. I went with .($fg-class-off)-(namespace)-reset as a naming convention since it resets any offset for that or larger namespaces due to the order of namespace declaration (same behavior as declaring column span on smaller applies to larger unless overridden).

In any case, I plan on updating docs, finish testing and cutting a release tonight. Thanks!

  • 👍1
matthewsimo commented

I've released 0.3.5 which includes this work, it can be seen here - 4a23ba1. Thanks everyone, enjoy.