mattiasw/ExifReader

XMP character encoding issue

Closed this issue · 5 comments

Hi,

I found a potential bug within the XMP tags:
I try to read the face regions that lightroom generate to a photo (in nodejs):
attribute mwg-rs:Name within ExifReader.load(data).Regions.value.RegionList.value[i].value['rdf:Description'].attributes['mwg-rs:Name']

The name should be special_chars űáéúőóüío?._: but instead I get: special_chars űáéúÅ�óüío?._:

Do you have any recommended solution for fixing it?

I'm using the following jpg for testing:

test image ouooueau-

Thanks!

Best,
Patrik
p.s.: really nice lib, thanks for the great work!. The only things that bothers me that with nodejs it has dependencies like jdataview that is needed to be somewhat 'mock'.
(And also Typescript type definitions would be nice :) )

Hi Patrik,

Thanks for the bug report. Can you try this branch? #47

If/when I get the time, I will look into type definitions and getting rid of jDataView as a dependancy in node.

Hi,

I can confirm that #47 works, thank you for the quick work!

That would be awesome!

Merged. Will do a publish to npm later. Thanks again for the report!

@bpatrik I don't know if the tagging worked in the PRs (your name was not auto-completed) so mentioning it here too. There are now two new PRs regarding your other suggestions: #48 and #49.

Hi,

Yes I saw them. Thank you very much!
I'll check both of them today/tomorrow.

Patrik