Update dependency to vite 4.0.0
Closed this issue · 5 comments
shinokada commented
When I update vite to 4.0.0, I get an warning:
WARN Issues with peer dependencies found
.
└─┬ mdsvexamples 0.3.2
└─┬ unplugin 0.7.2
└── ✕ unmet peer vite@"^2.3.0 || ^3.0.0-0": found 4.0.0
Can you update to vite 4.0.0?
mattjennings commented
can you try v0.3.3? https://github.com/mattjennings/mdsvexamples/releases/tag/0.3.3
shinokada commented
v0.3.3 has "vite": "^3.0.0"
.
As far as I know, It works with vite 4.0.0.
Are there any concerns that it won't work with vite 4.0.0?
mattjennings commented
No. The peer dependency warning came from unplugin, which I updated and doesn’t seem to have vite as a peer dep anymore.
If you’re not getting the peer dep warning with v0.3.3 then everything is good and I’ll close this issue.
…On Sat, Dec 10, 2022, at 2:20 AM, Shinichi Okada wrote:
v0.3.3 has `"vite": "^3.0.0"`.
As far as I know, It works with vite 4.0.0.
Are there any concerns that it won't work with vite 4.0.0?
—
Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCMY4U32ABEHCY5QQTFRZ3WMQ4NZANCNFSM6AAAAAASZ5IMHM>.
You are receiving this because you commented.Message ID: ***@***.***>
shinokada commented
Then can you update package.json?
mattjennings commented
It is a devDependency. It is not used when you install it.
Closing this as it is fixed, no peer dependency warning is shown anymore when installing in Vite 4 projects.
…On Sat, Dec 10, 2022, at 3:04 AM, Shinichi Okada wrote:
Then can you update package.json?
—
Reply to this email directly, view it on GitHub <#20 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCMY4R7Z2XSR2HJNPHRDHTWMRBRTANCNFSM6AAAAAASZ5IMHM>.
You are receiving this because you commented.Message ID: ***@***.***>