mattn/bsky

Asset name of darwin/amd64 is missing the version

Closed this issue · 5 comments

https://github.com/mattn/bsky/releases/tag/v0.0.63

bsky-darwin-.zip

image

Note

CLI Version Manager aqua supports bsky, but it failed to install bsky v0.0.63 on macOS, so I noticed this issue.

https://github.com/mattn/bsky/actions/runs/12020901190/job/33510365063#step:5:140

make[1]: gobump: No such file or directory
make[1]: *** [show-version] Error 1

make show-version failed because gobump isn't found.

There are several ways to solve this issue.

  1. Change GitHub Actions Runner from macos-latest to macos-13 #34
  2. Add $HOME/go/bin/darwin_amd64 to $PATH
  3. Change the release asset architecture from darwin/amd64 to darwin/arm64
  4. Release assets for both darwin/amd64 and darwin/arm64

About the option 3, I think the major architecture of macOS has been changed from amd64 to arm64.
Recent macOS uses apple silicon, and GitHub Actions runner macos-latest is also arm64.
So removing the support of darwin/amd64 is one option.

In my opinion, supporting both darwin/amd64 and darwin/arm64 is better.

I disagree with the option 2 as it's a bit tricky.

I have already created a pull request for the option 1 #34 , but if you prefer other options, I would address it.
What do you think? @mattn