Proposal: rename vendor to _vendor

Question

Proposal: rename vendor to _vendor

smira opened this issue 11 years ago · 8 comments

go tools ignore filenames that start with _ (and .). With current name of vendor subdirectory command go test ./... if run in repository root would go inside vendor subdirectory, find packages there and launch tests, which is usually not desired. The same applies to gom test ./... of course, and things like go tool vet.

If vendor is renamed to _vendor, this should make �./... work as expected again.

I can submit pull request if it sounds ok. Probably this could be configured in Gomfile?

Answer 1 · 2014-03-08T07:00:33.000Z

Looks like this would need to be modified in install.go. This is a good idea. 👍
Also a good chance to refactor the extra "vendor" tags into a constant.

Answer 2 · 2014-03-09T08:47:10.000Z

Implementation is trivial, I'm worried about backwards compatibility. @mattn, what do you think?

Answer 3 · 2014-03-10T00:40:52.000Z

Sorry for delay.

Answer 4 · 2014-03-10T12:00:14.000Z

Thanks a lot!

Answer 5 · 2014-03-12T15:29:59.000Z

Hmmmm, backwards compatibility indeed... took me a while to figure out why our go build was failing due to this change...

I have a feeling others may be in the same boat as this. Perhaps we can get a log line for what path exactly gom is downloading packages to on a 'gom install'?

Answer 6 · 2014-03-18T00:48:38.000Z

_vendor is definitely better then just "vendor", but what about ".gom" ? I personally think its nicer, and not as much as sore thumb as _vendor at the top of my project

Answer 7 · 2014-03-18T14:13:29.000Z

or .vendor ..

Answer 8 · 2014-03-18T14:50:45.000Z

You can also store this in ~/.gom/repos/.