rake all test failed

Question

rake all test failed

Closed this issue 12 years ago · 7 comments

rake all test was failed with mruby

Please see travis test.

https://travis-ci.org/matsumoto-r/mrbgem_test_ci/builds/22588120#L2034-L2040

Fail: $1 to $9
 - Assertion[1] Failed: Expected to be equal
    Expected: "aaab"
      Actual: nil
 - Assertion[2] Failed: Expected to be equal
    Expected: "b"
      Actual: nil

Answer 1 · 2014-04-11T08:45:11.000Z

@take-cheeze Would you mind that removing this part? https://github.com/mattn/mruby-onig-regexp/blob/master/src/mruby_onig_regexp.c#L124-L127
Any objection?

Answer 2 · 2014-04-11T11:11:49.000Z

@mattn I think it's unrelated to this issue.

It removes global variables "$#{last_match.length}" to "$9".
It's required to clear old match result.

I think mrb_gv_set failed because of other reason.

Answer 3 · 2014-04-11T13:04:43.000Z

Hmm, setting nil instead of removing should solve this.
Maybe mrb_gv_remove has some bug since there was khash changes to mruby recently.

Answer 4 · 2014-04-11T13:13:13.000Z

BTW mruby/mruby#2043 seems to fix this.

Answer 5 · 2014-04-11T15:18:10.000Z

This issue was fixed by mruby/mruby#2043, and mrbgem_test_ci is passed. Thanks!

Answer 6 · 2014-04-11T15:38:27.000Z

I'm sorry for my bug!

Answer 7 · 2014-04-12T10:13:07.000Z

@ksss No problem. Thanks for the fix!