mattn/p5-Growl-GNTP

Should list IO::Socket::PortState as a dependency

Closed this issue · 7 comments

jwm commented

Growl::GNTP won't work without IO::Socket::PortState, but it isn't listed as a dependency in cpanfile or META.*.

Fixed in ad7ea4b

jwm commented

Thanks. :-)

can somebody clarify /why/ it doesn't work without IO::Socket::PortState? I don't see it used anywhere in code.

mattn commented

Right, I don't remember why i did add this. Will remove in later if no problems.

If somebody works out why, perhaps a test could be added to demonstrate it, would remove doubt =)

Bah. Sorry about the git commit reference spam. I really wish github wasn't so magical :/

mattn commented

removed dependency of IO::Socket::PortState.