matyama/configs

Fix detection that python3.6 or python3.7 is already installed

Closed this issue · 1 comments

python3.6 python3.7: python
ifneq ($(shell which $@ 2> /dev/null),)
        @echo ">>> $$($@ --version) already installed"
else
        @echo ">>> Installing $@"
        sudo add-apt-repository -y ppa:deadsnakes/ppa      
        sudo apt update
        sudo apt install -y $@-dev $@-venv
endif

The issue is that $@ is not resolved at the time ifneq is evaluated and thus the rule always proceeds with an installation.

Fixed in c6837c6 by removing the installation check.