maubot/gitlab

gitlab test "Issues events" not working

Closed this issue · 1 comments

I can confirm that issues events are working in general, but when you trigger gitlab test for "Issues events" then is not working. Gitlab test push events and comments work as expected.

I'm pasting (masked) real examples

note-comment event

{
  "object_kind": "note",
  "event_type": "note",
  "user": {
    "name": "maskeduser",
    "username": "maskeduser",
    "avatar_url": "https://assets.gitlab-static.net/uploads/-/system/user/avatar/2/avatar.png"
  },
  "project_id": 1,
  "project": {
    "id": 1,
    "name": "test",
    "description": "",
    "web_url": "https://gitlab.com/maskeduser/test",
    "avatar_url": null,
    "git_ssh_url": "git@gitlab.com:maskeduser/test.git",
    "git_http_url": "https://gitlab.com/maskeduser/test.git",
    "namespace": "maskeduser",
    "visibility_level": 0,
    "path_with_namespace": "maskeduser/test",
    "default_branch": "master",
    "ci_config_path": null,
    "homepage": "https://gitlab.com/maskeduser/test",
    "url": "git@gitlab.com:maskeduser/test.git",
    "ssh_url": "git@gitlab.com:maskeduser/test.git",
    "http_url": "https://gitlab.com/maskeduser/test.git"
  },
  "object_attributes": {
    "attachment": null,
    "author_id": 2,
    "change_position": null,
    "commit_id": null,
    "created_at": "2017-07-25 18:04:27 UTC",
    "discussion_id": "4f205ed1a1cc2e388d426f6fbebe14324f9e4d64",
    "id": 35893098,
    "line_code": null,
    "note": "changed time estimate to 1h",
    "noteable_id": 6223732,
    "noteable_type": "Issue",
    "original_position": null,
    "position": null,
    "project_id": 1,
    "resolved_at": null,
    "resolved_by_id": null,
    "resolved_by_push": null,
    "st_diff": null,
    "system": true,
    "type": null,
    "updated_at": "2017-07-25 18:04:27 UTC",
    "updated_by_id": null,
    "description": "changed time estimate to 1h",
    "url": "https://gitlab.com/maskeduser/test/issues/5#note_35893098"
  },
  "repository": {
    "name": "test",
    "url": "git@gitlab.com:maskeduser/test.git",
    "description": "",
    "homepage": "https://gitlab.com/maskeduser/test"
  },
  "issue": {
    "author_id": 2,
    "closed_at": null,
    "confidential": false,
    "created_at": "2017-07-25 17:17:19 UTC",
    "description": "",
    "due_date": null,
    "id": 6223732,
    "iid": 5,
    "last_edited_at": "2017-07-26 06:50:06 UTC",
    "last_edited_by_id": 2,
    "milestone_id": null,
    "moved_to_id": null,
    "project_id": 1,
    "relative_position": 1073744323,
    "state": "opened",
    "time_estimate": 7200,
    "title": "new issue (title edited)",
    "updated_at": "2018-01-11 00:30:49 UTC",
    "updated_by_id": 2,
    "weight": 4,
    "url": "https://gitlab.com/maskeduser/test/issues/5",
    "total_time_spent": 14400,
    "human_total_time_spent": "4h",
    "human_time_estimate": "2h",
    "assignee_ids": [

    ],
    "assignee_id": null,
    "labels": [
      {
        "id": 3295834,
        "title": "Doing",
        "color": "#5CB85C",
        "project_id": 1,
        "created_at": "2018-01-10 21:29:10 UTC",
        "updated_at": "2018-01-10 21:29:10 UTC",
        "template": false,
        "description": null,
        "type": "ProjectLabel",
        "group_id": null
      }
    ]
  }
}

push event

{
  "object_kind": "push",
  "event_name": "push",
  "before": "11382400719febfa6877c23462d1ee2262725b63",
  "after": "d696de28cd8e99f33fe21458d7717b0c8738a950",
  "ref": "refs/heads/master",
  "checkout_sha": "d696de28cd8e99f33fe21458d7717b0c8738a950",
  "message": null,
  "user_id": 2,
  "user_name": "maskeduser",
  "user_username": "maskeduser",
  "user_email": "",
  "user_avatar": "https://assets.gitlab-static.net/uploads/-/system/user/avatar/2/avatar.png",
  "project_id": 1,
  "project": {
    "id": 1,
    "name": "test",
    "description": "",
    "web_url": "https://gitlab.com/maskeduser/test",
    "avatar_url": null,
    "git_ssh_url": "git@gitlab.com:maskeduser/test.git",
    "git_http_url": "https://gitlab.com/maskeduser/test.git",
    "namespace": "maskeduser",
    "visibility_level": 0,
    "path_with_namespace": "maskeduser/test",
    "default_branch": "master",
    "ci_config_path": null,
    "homepage": "https://gitlab.com/maskeduser/test",
    "url": "git@gitlab.com:maskeduser/test.git",
    "ssh_url": "git@gitlab.com:maskeduser/test.git",
    "http_url": "https://gitlab.com/maskeduser/test.git"
  },
  "commits": [
    {
      "id": "d696de28cd8e99f33fe21458d7717b0c8738a950",
      "message": "test\n",
      "timestamp": "2018-06-06T01:58:38Z",
      "url": "https://gitlab.com/maskeduser/test/commit/d696de28cd8e99f33fe21458d7717b0c8738a950",
      "author": {
        "name": "maskeduser",
        "email": "maskedemail@example.com"
      },
      "added": [

      ],
      "modified": [
        "README.md"
      ],
      "removed": [

      ]
    },
    {
      "id": "1adeafcc60f3599c89f0974b14aeec4ea73f5422",
      "message": "more\n",
      "timestamp": "2018-06-06T01:53:43Z",
      "url": "https://gitlab.com/maskeduser/test/commit/1adeafcc60f3599c89f0974b14aeec4ea73f5422",
      "author": {
        "name": "maskeduser",
        "email": "maskeduser@example.com"
      },
      "added": [

      ],
      "modified": [
        "README.md"
      ],
      "removed": [

      ]
    },
    {
      "id": "11382400719febfa6877c23462d1ee2262725b63",
      "message": "my change\n",
      "timestamp": "2018-06-06T01:47:57Z",
      "url": "https://gitlab.com/maskeduser/test/commit/11382400719febfa6877c23462d1ee2262725b63",
      "author": {
        "name": "maskeduser",
        "email": "localhost"
      },
      "added": [

      ],
      "modified": [
        "README.md"
      ],
      "removed": [

      ]
    }
  ],
  "total_commits_count": 3,
  "push_options": {
  },
  "repository": {
    "name": "test",
    "url": "git@gitlab.com:maskeduser/test.git",
    "description": "",
    "homepage": "https://gitlab.com/maskeduser/test",
    "git_http_url": "https://gitlab.com/maskeduser/test.git",
    "git_ssh_url": "git@gitlab.com:maskeduser/test.git",
    "visibility_level": 0
  }
}

issue event

{
  "object_kind": "issue",
  "event_type": "issue",
  "user": {
    "name": "maskeduser",
    "username": "maskeduser",
    "avatar_url": "https://assets.gitlab-static.net/uploads/-/system/user/avatar/2/avatar.png"
  },
  "project": {
    "id": 1,
    "name": "test",
    "description": "",
    "web_url": "https://gitlab.com/maskeduser/test",
    "avatar_url": null,
    "git_ssh_url": "git@gitlab.com:maskeduser/test.git",
    "git_http_url": "https://gitlab.com/maskeduser/test.git",
    "namespace": "maskeduser",
    "visibility_level": 0,
    "path_with_namespace": "maskeduser/test",
    "default_branch": "master",
    "ci_config_path": null,
    "homepage": "https://gitlab.com/maskeduser/test",
    "url": "git@gitlab.com:maskeduser/test.git",
    "ssh_url": "git@gitlab.com:maskeduser/test.git",
    "http_url": "https://gitlab.com/maskeduser/test.git"
  },
  "object_attributes": {
    "author_id": 2,
    "closed_at": null,
    "confidential": false,
    "created_at": "2017-07-25 17:10:57 UTC",
    "description": "asdfasdf",
    "due_date": null,
    "id": 6223691,
    "iid": 1,
    "last_edited_at": null,
    "last_edited_by_id": null,
    "milestone_id": null,
    "moved_to_id": null,
    "project_id": 1,
    "relative_position": 1073742323,
    "state": "opened",
    "time_estimate": 0,
    "title": "test",
    "updated_at": "2018-01-10 21:29:13 UTC",
    "updated_by_id": 2,
    "weight": null,
    "url": "https://gitlab.com/maskeduser/test/issues/1",
    "total_time_spent": 0,
    "human_total_time_spent": null,
    "human_time_estimate": null,
    "assignee_ids": [

    ],
    "assignee_id": null,
    "labels": [

    ]
  },
  "labels": [

  ],
  "changes": {
    "total_time_spent": {
      "previous": null,
      "current": 0
    }
  },
  "repository": {
    "name": "test",
    "url": "git@gitlab.com:maskeduser/test.git",
    "description": "",
    "homepage": "https://gitlab.com/maskeduser/test"
  }
}
tulir commented

The reason for this is that the test issue event only says the total_time_spent changed from null to 0