mauricew/ruby-twitch-api

Enable changing Faraday Adapter

craysiii opened this issue · 4 comments

craysiii commented

Hey there,

I think it would be really helpful to be able to change the Faraday adapter. Willing to make a PR but don't know exactly how you'd want it implemented. Care to discuss?

mauricew commented

I'll look into this for a near future release. Chances are it could probably be added as an additional kwarg to the client constructor.

craysiii commented

Sounds good. :)

AlexWayfer commented

I think I can make it (I did it in another gem).

I know, it's pretty old issue, but I have the question: as I see, you can change an adapter for existing connection:

Twitch::Client::CONNECTION.adapter :excon
# => Faraday::Adapter::Excon

Is it resolves the issue for you or do we still need for some options in Twitch?

AlexWayfer commented

Also as a note, you can setup Faraday.default_adapter = :excon anywhere (before lib initialization).

I'm going to close this issue for now because I see solutions for the problem.

If you want something else related to this, different approach — feel free to write.