mawerty/Is-Prime

Is there something that I should do?

Opened this issue · 8 comments

mawerty commented

Is there something that I should do like better Readme, better contribution guidelines or something?

teub commented

It would be a lot more safer if you add unit tests and continuous integration but I'm afraid it's a lot of work

  • 👍4
mawerty commented

The problem is that I've never written unit tests, so I don't know how to do them, and the same goes for continuous integration. And second problem is that every PR is in different language so i would need to create something that can compile and test every language.

teub commented

If you had to pick just one language, Javascript is probably going to be the most used package

PalmDevs commented

CI would be hell to setup 😅

jeanlucaslima commented
  1. At least guarantee every code is responding false to any test against a number, some implementations are just "false"
  2. Create executable binaries to use as command line
jeanlucaslima commented

One extra: a landing page using github to show it in action

PalmDevs commented
  1. At least guarantee every code is responding false to any test against a number, some implementations are just "false"
  2. Create executable binaries to use as command line

That would require a single workflow to set up ALL THE THINGS to test. Unless we split workflows into one for each and every languages, which is doable.

mawerty commented

One extra: a landing page using github to show it in action

I pressed some random buttons and the page is now available here: https://mawerty.github.io/Is-Prime/ . I put link in About section. Should I put the link in Readme or something?

  • ❤️4
  • 🚀3