max-mapper/menubar

[Windows 10 pro] Application getting cutoff if taskbar is vertical

tboulis opened this issue · 4 comments

tboulis commented

Description

The menubar window is not full visible (bottom is getting cut off) with this arrangement:

  • Windows 10 Pro
  • 3 monitors (1 laptop, 2 standalone)
  • Windows task bar is on the right side of the screen (vertical)

The hidden part of the app has roughly 200px height

Specifications

  • Menubar version: 9.0.1
  • Platform: Windows 10 Pro version 1083
  • Electron version: 9.2.1

Other information

Could be related to this PR: #217

Screenshot

image

semenov-oleg commented

@amaurymartiny I've found that the following code is responsible for this issue
https://github.com/maxogden/menubar/blob/master/src/Menubar.ts#L180-L193
Could you explain please what is the reason to optimize vertical position? Maybe would another way be more effective?

amaury1093 commented

Yes, I believe that code was written before I became maintainer.

Maybe would another way be more effective?

Feel free to improve with a PR!

semenov-oleg commented

Ok. I'm going to remove this code. I've checked locally on Windows with 2 monitors. Seems that project works fine without this 'optimization'