maxim-zhao/SidWizPlus

Don't read silent External Trigger when actual Audiable Track is Silent

FlygonAU opened this issue · 3 comments

https://cdn.discordapp.com/attachments/327805534793105411/851133376101482558/unknown.png
For some visual reference.

The top audio file is the External Trigger clock, and the bottom audio file is the actual audio/what is being seen by the viewer.

The External Trigger having a set clock whilst the audio is actually silent is causing some really really bad visual bugs that are unfixable unless you outright don't use the External Trigger, or manually mute the sections of the clock actually causing issues.
Visually, the timbre winds up not locking onto its actual pitch at all, but rather into the sections outside of the audiable range to the 'left' and 'right' of the track.

Hmm, odd - it ought to render the silence according to the trigger point anyway. I'll have to experiment a bit.

Fixed by 5fa0c03