maxim-zhao/psrp

(Feature Request) Force definite articles on certain lines of text

Opened this issue · 3 comments

For the following messages, I feel like it would sound more natural if the definite article was used, even if the item in question has an indefinite article:

  • Someone has used <article><item> up.
  • But <article><item> is of no use here.
  • The group boarded <article><item>.
  • The group got out of <article><item>.
  • [You dropped <article><item>, and] you got <article><item>. (The line in square brackets does not apply and is only provided for context)
  • Do you want to abandon <article><item>?
  • You abandoned <article><item>.
  • You can’t drop <article><item>!

For English, it'd fortunately only be a matter of substituting a/an with the and A/An with The, but languages with gendered nouns (i.e. all the languages other than English) may need a more refined solution.

I think some of these are best left indefinite:

  • But <article><item> is of no use here.
  • You can’t drop <article><item>!

...as they refer to items of those types in general, not the specific ones you have.

These are already always definite, at least in English and German?

  • The group boarded <article><item>.
  • The group got out of <article><item>.

Does it become more necessary in German?

Fair enough, I concede on your points for the most part.

Does it become more necessary in German?

If you're talking about the vehicle names, I think the German script currently has the article hardcoded because <acc> hadn't been implemented at the time I translated that bit.

If you mean the lines themselves, though, of the ones you contested, they'd work with indefinite articles in German in hindsight, too. Or at least most if not all undroppable items are already using definite articles, anyway. The sole exception I can think of is the Alsuline item using an indefinite article in English (and probably most of the Romance language translations, too), even though there's only one of it, but that may be a story for a separate issue.

I'm increasingly thinking every item in the game needs to define its indefinite and definite articles, and the script needs to swap <article> for <the> and <a> (for English). This is quite a departure from the existing setup, where every item is either always definite or indefinite. However sometimes we need to force definite mode, e.g. talking about the Aeroprism or the Shield of Perseus, and I can imagine that in some languages that might change the grammar of the whole sentence beyond a simple article.