maximevaillancourt/digital-garden-jekyll-template

wikilink to missing note beaks footnote

dennisseidel opened this issue · 2 comments

Describe the bug
Creating wiki style links [[something]] to a note that doesn't exist in footnotes break the parser.

To reproduce
Steps to reproduce the behavior:

  1. Create a new note e.g. test.md
---
title: 'Test note '
---

Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. [^1]

Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tempor invidunt ut labore et dolore magna aliquyam erat, sed diam voluptua. At vero eos et accusam et justo duo dolores et ea rebum. Stet clita kasd gubergren, no sea takimata sanctus est Lorem ipsum dolor sit amet. [^2]

[^1]: This links to an non existing note [[doesnot exist yet]]
[^2]: Sample footnote 2.
  1. Start the application and go to the note.
  2. See the broken footnote (see screenshot below). The footnote breaks in two parts and displays an element.

Expected behavior
The footnotes is displayed with the link inside the footnote as written in the markdown.

Screenshots
Screenshot 2021-09-15 at 23 17 13

Desktop (please complete the following information):

  • Operating system: macOS 11.6
  • Ruby version: ruby 3.0.1

Thanks for the report! Great catch. 🙏

This is now fixed. You may update your fork to pull the latest changes on the master branch of this repository. ✔️

Thank you for the super-fast fix 🙏 I'll check your fix out to get a better understanding of the codebase so next time I can make such small things a pull request 🙂 Really appreciate your effort!