Add support for very long BC dates on `wikidataTimeToISOString`

Question

Add support for very long BC dates on `wikidataTimeToISOString`

moshest opened this issue 7 years ago · 3 comments

I'm not familiar with any time frame limitation for the ISO format.

I think that the method wikidataTimeToISOString should always return a valid ISO string even if the date if not valid of native Date object. This behaviour is more consistent.

For example:

wdk.wikidataTimeToISOString('-13798000000-00-00T00:00:00Z')
'-13798000000-01-01T00:00:00Z'

Answer 1 · 2018-05-10T06:26:53.000Z

should be fixed by 0406b47, published in v5.9.6

Answer 2 · 2018-05-10T06:57:30.000Z

Great!

You may update the docs as well:
https://github.com/maxlath/wikidata-sdk/blob/98af9ffcba406e946700601e19423e21f487977a/docs/general_helpers.md#wikidatatimetoisostring

Answer 3 · 2018-05-10T11:41:46.000Z

@moshest thanks for spotting!