CMake issue with missing file t/libtap

[bsergean]

It looks like some unittest C files are missing: on macOS with XCode 12 I'm getting those errors after typical cmake invocation. There is an empty t/libtap folder.

mkdir build
cd build
cmake ..

....
INSTALL TARGETS - target maxminddb has PUBLIC_HEADER files but no PUBLIC_HEADER DESTINATION.
-- Configuring done
CMake Error at t/CMakeLists.txt:1 (add_library):
Cannot find source file:

libtap/tap.c

Tried extensions .c .C .c++ .cc .cpp .cxx .cu .m .M .mm .h .hh .h++ .hm
.hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .ispc

CMake Error at t/CMakeLists.txt:1 (add_library):
No SOURCES given to target: tap

It's probably worth adding an option to disable building unittest when building.

Another tip (I hope I can help), is that using target_* family of functions should make it easier to use CMake tools such as FetchContent which are great for bringing in third party libraries easily.

[oschwald]

How are you downloading the source code? If you are cloning the repo, you will need to download the submodules as well. If you are downloading it from the release section, please use the named release files, e.g., libmaxminddb-1.4.3.tar.gz, rather than the files automatically generated by GitHub.

[bsergean]

Ah that must be it, I just cloned the repo without using the --submodule option (--recursive ?).

…

On Oct 31, 2020, at 12:56 PM, Gregory Oschwald ***@***.***> wrote: How are you downloading the source code? If you are cloning the repo, you will need to download the submodules as well. If you are downloading it from the release section, please use the named release files, e.g., libmaxminddb-1.4.3.tar.gz <https://github.com/maxmind/libmaxminddb/releases/download/1.4.3/libmaxminddb-1.4.3.tar.gz>, rather than the files automatically generated by GitHub. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#242 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UISVDT4IBF4YONEFWLSNRTV3ANCNFSM4TGCFFPQ>.

[oschwald]

If you've already cloned it, git submodule update --init --recursive should do the trick.

[bsergean]

Yes that fixed the problem. But now the next one is :) .... build$ make Scanning dependencies of target maxminddb [ 1%] Building C object src/CMakeFiles/maxminddb.dir/maxminddb.c.o In file included from /Users/bsergeant/src/foss/libmaxminddb/src/maxminddb.c:4: In file included from /Users/bsergeant/src/foss/libmaxminddb/src/data-pool.h:4: /Users/bsergeant/src/foss/libmaxminddb/include/maxminddb.h:20:10: fatal error: 'maxminddb_config.h' file not found #include "maxminddb_config.h" ^~~~~~~~~~~~~~~~~~~~ 1 error generated. target_include_directory might fix it, or the config file is not generated in the right spot ? Ironically I am working on adding CMake support to another C library, maybe there are some interesting stuff over there ? https://github.com/bsergean/libdeflate/blob/master/programs/CMakeLists.txt <https://github.com/bsergean/libdeflate/blob/master/programs/CMakeLists.txt> https://github.com/bsergean/libdeflate/blob/master/CMakeLists.txt

…

On Oct 31, 2020, at 12:59 PM, Gregory Oschwald ***@***.***> wrote: git submodule update --init --recursive

[oschwald]

The cmake build files are brand new and likely have rough edges. You can see how they are currently tested on macOS, Windows, and Linux via the GitHub Action. They were primarily added to replace an poorly aging MSBuild files for Windows. A PR to improve them for more use cases would definitely be appreciated.

[bsergean]

Thanks for the pointers Gregory, I'll look at the GitHub actions for more details, and hopefully I can contribute something to make it better.

…

On Nov 2, 2020, at 8:00 AM, Gregory Oschwald ***@***.***> wrote: The cmake build files are brand new and likely have rough edges. You can see how they are currently tested on macOS, Windows, and Linux via the GitHub Action. They were primarily added to replace an poorly aging MSBuild files for Windows. A PR to improve them for more use cases would definitely be appreciated. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#242 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC2O6UOSWORPJRHNEY2BXD3SN3JSLANCNFSM4TGCFFPQ>.

[bsergean]

Here we go, I tried to improve the cmake files ; now they let me build on my mac, and I can make install it and the output look good. The library can be used externally with FetchContent now.