maxnowack/node-podcast

Optional buildDate in output

Closed this issue · 2 comments

andreasvirkus commented

Hi!

I'm writing a Metalsmith plugin/wrapper for your package (https://github.com/andreasvirkus/metalsmith-podcast) and was wondering if you'd consider an additional option to hide the lastBuildDate from the output (would default to being included)?

It'd make it easier to write tests for the plugin (currently trying to use asset-dir-equal) and it'd make it easier to commit the expected build results to the repo.

Willing to make a PR about this if you'd accept it.

Best,
Andreas

maxnowack commented

I think lastBuildDate is pretty common in RSS and also in podcast feeds. Yes, create a PR and I will accept it :)

maxnowack commented

lastBuildDate is coming from the rss package.
I'll close this issue, since it can't be fixed in this repository.
Hint: You can use mockdate for testing ;)

  • 👍2