Bounty Hunter types are flipped the wrong way.
Closed this issue · 2 comments
Hey @maxswa , been using your API for a Twitch bot I'm working on. Super cool. I noted the Bounty Hunter stats are wrong however. 99% sure it's due to the order here not matching the order in the hiscores. would have commited the change myself but I can't seem to be able to make branches.
osrs-json-hiscores/src/utils/constants.ts
Line 62 in 2f788fa
Should be this I believe:
export const BH_MODES: BHType[] = ['hunter', 'rogue'];
Thanks for reporting this bug! This must have been changed at some point without warning. The struggles of using an unofficial API... I can make this change and publish a new version today.
In the future, if you want to contribute to an open source repo you need to fork it, make changes on your fork, then make a PR. Here's some documentation on making a PR from a fork creating-a-pull-request-from-a-fork
Awesome thanks appreciate it! I knew there should be a way to do it I just don't contribute to open source enough 😬