Should TherianContext:L133 use Validate.validState(opOnPop.equals(operation)) ?

Question

Should TherianContext:L133 use Validate.validState(opOnPop.equals(operation)) ?

Closed this issue 12 years ago · 2 comments

Hi again Matt,

Should this

Validate.validState(opOnPop == operation,

Be replaced by this?

Validate.validState(opOnPop.equals(operation),

Just going through some static analysis in therian, and the tool spotted this.

Cheers, -B

Answer 1 · 2012-08-04T17:23:32.000Z

I don't think so; I just do things like this to make sure I'm tracking stack state as expected, and in this case I would expect the same instance. Does that make sense?

Answer 2 · 2012-08-04T22:55:53.000Z

Yeah, it does. I didn't read the code very well, and couldn't find another way to add a comment with the question, that's why I filled this issue :-) closing now, thanks Matt.