mbhynes/fzf-gcloud

Suggestion: use a key binding other than CTRL+P

Closed this issue ยท 4 comments

As you probably know, CTRL, P is a "known" keybinding in the shell (brings up the previous command).

I think it's better to default to another keybinding. A keybinding that comes to my mind is CTRL, G (G for gcloud)

I created a PR to change it to CTRL, G instead; let me know what you think

That's a good point! I typically use vi-like keybindings to edit cli input/command history, so I overlooked this. I'm searching for the default bash keybindings with man bash and it looks like C-g is taken for some other default. Also, in truth, I'm not a huge fan of g (find it a bit uncomfortable personally). But CTRL-i looks free, and is somewhat mnemomic for information. How about this?

Patched to CTRL-I in #5

Good point about a "free" keybinding ๐Ÿ‘

TBH I think the ideal way to do this would be to somehow expose a function and include instructions on how to use a keybinding to call that function.

It might be a bit "intrusive" to force a keybinding to the user, but of course it's up to you ๐Ÿ™‚

TBH I think the ideal way to do this would be to somehow expose a function and include instructions on how to use a keybinding to call that function.

Absolutely. I'm actually surprised this was useful enough to warrant putting that in the v2 roadmap ... ๐Ÿ˜„