Make the `play_at` API accept other sample types than f32.

Question

Closed this issue 4 years ago · 3 comments

Currently the play_at function expects sources with sample type f32 because that is what's internally used.

Converting sources from other types requires annoying boilerplate #5.

It should be possible to make the function generic to accept any type that can be safely cast to f32.

Answer 1 · 2021-02-08T18:10:02.000Z

Would play_omni benefit from this as well?

Answer 2 · 2021-02-08T19:13:30.000Z

Yes, absolutely.

Answer 3 · 2021-02-09T16:01:07.000Z

Turns out Rodio sources expose a .convert_samples() method which seems to be convenient enough to use.

I'll rather avoid reimplementing the conversion because Rodio is more likely to get it right.