mbraak/django-file-form

Upgrade to latest version is failing

sks444 opened this issue · 5 comments

sks444 commented

We just upgraded our django-file-form version to 3.1.2. And the ci is failing with following message:

Migrations for 'django_file_form':
  venv/lib/python3.7/site-packages/django_file_form/migrations/0007_auto_20210118_1009.py
    - Create model TemporaryUploadedFile
    - Delete model UploadedFile

It looks like the existing model(UploadedFile) was renamed to TemporaryUploadedFile in #394 but the migrations file for same was not added.

mbraak commented

The same table name is used, so the migration should not be necessary: db_table = "django_file_form_uploadedfile"
https://github.com/mbraak/django-file-form/pull/394/files#diff-49a64a3dec583dfd1ea8bd1f7177c199888444ad049f05c06f445f08baefffa2R79

I will try to reproduce the error.

sks444 commented

Sure.

There usually is a migrations file with RenameModel operation in this case.

mbraak commented

Ok, thanks. I will add the migration.

mbraak commented

Fixed in version 3.1.3

sks444 commented

Thanks @mbraak for the quick release!