Suspicious CMake variables

[GoogleCodeExporter]

Currently, end user can't set the (advanced) BULLET_INCLUDE_DIR variable 
because the FindBullet.cmake script unsets it and resets it during each 
configure. Currently investigating to see whether or not the need to set this 
variable is made moot by use of BULLET_INCLUDE_DIR / BULLET_SOURCE_DIR, and 
what the most appropriate change (if any) is.

Original issue reported on code.google.com by SkewMat...@gmail.com on 25 Feb 2010 at 9:17

[GoogleCodeExporter]

I've run into this issue as well and solve it by adding a couple of extra paths 
to the FindBullet.cmake file:


--- FindBullet.cmake    (revision 89)
+++ FindBullet.cmake    (working copy)
@@ -29,10 +29,12 @@
         $ENV{BULLET_ROOT}
         ${BULLET_SOURCE_DIR}
         $ENV{BULLET_SOURCE_DIR}
+        /usr/local/
         "C:/Program Files/BULLET_PHYSICS"
     PATH_SUFFIXES
         /src
         /include
+        /include/bullet
     )
 IF( BULLET_INCLUDE_DIR )
     SET( BULLET_EXTRAS_INCLUDE_DIR ${BULLET_INCLUDE_DIR}/../Extras )
@@ -52,6 +54,7 @@
             $ENV{BULLET_ROOT}
             ${BULLET_BUILD_DIR}
             $ENV{BULLET_BUILD_DIR}
+            /usr/local/
             "C:/Program Files/BULLET_PHYSICS"
         PATH_SUFFIXES
             ./src/${DIRNAME}

Original comment by andy.som...@gmail.com on 13 Sep 2010 at 10:09

[GoogleCodeExporter]

Thanks, I can take a look at adding that patch after I get back in the office 
next week (travelling this week).

But when I go into CMake and look at some of the Find*.cmake module scripts 
that it ships with, seems like they're using some new techniques for finding 
dependencies that I'm not familiar with. It might be worth learning the new 
pattern and rewriting our Find*.cmake scripts to match. Then, after that is 
done, I'd like to just submit them to the CMake project.

Original comment by SkewMat...@gmail.com on 13 Sep 2010 at 11:37

[GoogleCodeExporter]

I'm going to resolve this issue.

Current svn trunk of osgBullet uses the stock FindBullet.cmake script that 
ships with CMake. If you don't have it. please upgrade to latest CMake.

Because we're now using the stock script, there's no practical way for me to 
add the change from comment #1 above. If these paths need to be added to the 
stock script, this is a CMake bug.

I've added a FindBulletHelper.cmake script, which puts a pulldown menu in the 
cmake-gui to allow you to specify the Bullet install type. Select the type, hit 
configure, and provide values for any variables that pop up.

The FindBulletHelper will be useful in cases where the stock script is unable 
to locate your Bullet install. You can select "Alternate Install Location" and 
provide the root of your Bullet install dir, for example.

Original comment by SkewMat...@gmail.com on 14 Dec 2010 at 7:38

• Changed state: Fixed