mcsiple/mmrefpoints

AEP: 26_make_ptable.R

mcsiple opened this issue · 2 comments

mcsiple commented
  • You need to add a return statement
  • It is a pity mnpl is not computed from the parameters in lh.parms
  • Check there are enough years
  • Do you need lh.params given the list from projections should contain all the needed parameters
  • I can’t get this to work!! What am I passing wrong..
  • check AEP edits in doc (attached to email)
mcsiple commented

MNPL is specified in the function because the user specifies MNPL in Shiny. I have added an option to calculate MNPL if and only if MNPL is not provided by the user ( commit ec78b75 ). More fixed later!

mcsiple commented

Rest of comments fixed with commit c511156 and d4f05c3.