md-y/mangadex-full-api

TypeScript error on UploadSession.commit()

Closed this issue · 1 comments

MxBlu commented

Can't wrap my head around this one, for some reason, TS can't see the def of Chapter in the return type of commit().
I'm on TS 4.4.2, but I also note the error when using the version in package.json (4.1.3).

image

Also FYI there's also some rest parameters that are marked as optional, which the compiler doesn't like. No need for them to be, so can get rid of them:
image

I'd PR it but no point of only fixing most of the TS errors and not all of them.

md-y commented

The chapter issue is due to the poor script that was compiling index.d.ts. It's now handled by another module.

Both issues are fixed for 5.6.0