Units for time?
michaeltryby opened this issue · 2 comments
michaeltryby commented
@mdbartos Nice work!
I noticed in run.py that _dt=1e-6. What units are time in?
mdbartos commented
Greetings,
Units are in seconds.
Keep in mind that the current code is very preliminary. I haven't reproduced the results for Ji's test case yet. I need to add some new code to handle cases where certain quantities (coefficients) are zero.
michaeltryby commented
Just thinking ahead. This algorithm is designed to be efficient, but requires a small time step for numerical stability. As a result the performance is somewhat lackluster. Trying to figure out how to make the time-step larger and improving performance would be something interesting you can look at that would constitute an original research contribution.
If you are interested.